feat: Convert CumeDist to UDWF #13051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
github-actions
bot
added
the
documentation
findepi
approved these changes
Oct 22, 2024
| CUME_DIST() OVER(ORDER BY c9) as cd1, | ||
| CUME_DIST() OVER(ORDER BY c9 ROWS BETWEEN 10 PRECEDING and 1 FOLLOWING) as cd2 | ||
| cume_dist() OVER(ORDER BY c9) as cd1, | ||
| cume_dist() OVER(ORDER BY c9 ROWS BETWEEN 10 PRECEDING and 1 FOLLOWING) as cd2 |
There was a problem hiding this comment.
It is consistent with conversion of other user-defined window functions.
|
@jonathanc-n A roundtrip test for datafusion/datafusion/proto/tests/cases/roundtrip_logical_plan.rs Lines 943 to 952 in c22abb4 |
jcsherin
reviewed
Oct 22, 2024
| @@ -940,6 +940,7 @@ async fn roundtrip_expr_api() -> Result<()> { | |||
| vec![lit(1), lit(2), lit(3)], | |||
| vec![lit(10), lit(20), lit(30)], | |||
| ), | |||
| cume_dist(), | |||
alamb
approved these changes
Oct 22, 2024
| - [dense_rank](#dense_rank) | ||
| - [percent_rank](#percent_rank) | ||
| - [rank](#rank) | ||
| - [row_number](#row_number) | ||
|
|
||
| ### `cume_dist` |
|
Love it -- thank you @jonathanc-n and @findepi @timsaucer and @jcsherin for the reviews |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12695 .
Rationale for this change
What changes are included in this PR?
Converted CumeDist to user defined window function.
Are these changes tested?
Are there any user-facing changes?